Daniel Fuchs
Daniel Fuchs
In addition to Alan's remarks I believe we need new tests to verify the new behavior.
> Is there any value in keeping `SubjectDelegationPermission` after this change? If so, I would mark that API deprecated for removal, so that it can be removed in the next...
Changes to jdk.net and jdk.sctp look ok.
> Should we be setting any expectations by specifying what InetAddress.getHostAddress() will return for an Inet4Address constructed using this new Inet4Address.ofPosixLiteral() method? In its current form I believe it will...
> The changes proposed in this PR introduce a new paragraph in the class level documentation just before the line which states the dotted-quad string. So I think it may...
> which lists the methods that parse as decimal only, and the new method which parses using the "loose" syntax. That might not be practical: the only method that supports...
> I think we only need to talk about the methods in InetAddress. Though it could be phrased as `ofPosixLiteral` supports decimal, hex and octal. All other parsing is decimal...
> Thanks @Michael-Mc-Mahon, @jaikiran. I updated the class level doc so that the sentence "These forms support parts in decimal format only" is completely removed (it wasn't looking good to...
Thanks - LGTM now. @AlekseiEfimov, @Michael-Mc-Mahon are you also good with this version of the changes?