Daniel Fuchs
Daniel Fuchs
I am approving on the condition to make sure that all JNDI tests (as well as tier1, tier2, tier3) are run before integrating.
Also please get an approval from a security-libs maintainer for the changes to the security properties file before integrating.
> 'in' is a protected field so it requires thinking about subclasses that might change 'in', say when the input stream is asynchronously closed. BufferedInputStream is an example of a...
> > I agree that caution is warranted > > But assuming I've reverted the changes that are dubious, how could there be bugs caused by replacement of multiple reads...
> I can't imagine a subclass of DataInputStream setting 'in' to null. If it handles async close then it's possible that it replaces it with an input stream where read...
Done! Thanks for reminding me.
If you need a sponsor please drop a note here after integrating.
A draft CSR can be seen here: https://bugs.openjdk.org/browse/JDK-8328100 Diff of the doc changes will be pasted into the CSR after this PR is reviewed. Let's agree on the wording here...