Window pos

[Stateford]

Implemented #36. Saves window position when minimized and when the window is closing.

[Stateford]

@dfs-minded Hello! Why was this assigned to me? Is there something that must be changed?

[dfs-minded]

Hi Dimitri! Yes, sorry, forgot to click submit a review. Could you please apply that small changes so I can merge the pull request into mainline? Regards, Anna

On Wed, Oct 16, 2019 at 5:55 PM Dimitri Apostal [email protected] wrote:

@dfs-minded https://github.com/dfs-minded Hello! Why was this assigned to me? Is there something that must be changed?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dfs-minded/indexer-plus-plus/pull/49?email_source=notifications&email_token=ADJD433REQL3JLPDLQFEP6TQO42OXA5CNFSM4GXVJA22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBNAKRY#issuecomment-542770503, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJD435GNTWXFTLFXGWZOQTQO42OXANCNFSM4GXVJA2Q .

[Stateford]

I tried making changes on a new computer and I seem to be running into some build issues.

When I build for "Any CPU" it causes a runtime error caused by mismatched process architecture.

System.BadImageFormatException: 'Could not load file or assembly 'CLIInterop, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. An attempt was made to load a program with an incorrect format.'

When I build for x86 as suggested, it causes a bunch of warnings about "std::wstring" not being part of the std library (the string header is never included).

Here are a few of the errors

1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(21): error C2039: 'wstring': is not a member of 'std'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(20): note: see declaration of 'std'
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(21): error C2061: syntax error: identifier 'wstring'
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C2039: 'wstring': is not a member of 'std'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(20): note: see declaration of 'std'
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C2065: 'wstring': undeclared identifier
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C2923: 'std::vector': 'wstring' is not a valid template type argument for parameter '_Ty'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(352): error C3203: 'allocator': unspecialized class template can't be used as a template argument for template parameter '_Alloc', expected a real type
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C3203: 'vector': unspecialized class template can't be used as a template argument for template parameter '_Ty', expected a real type
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(33): error C2039: 'wstring': is not a member of 'std'
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(20): note: see declaration of 'std'
1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(33): error C2065: 'wstring': undeclared identifier

[dfs-minded]

Hi Dimitri! Looks like there are missing library. Do you have CLIInterop on your machine? There are some options in the Visual studio installer where you need to select them to have installed the libraries for C++/C# interoperability. Let me know if you found them.

On Sat, Oct 19, 2019, 23:27 Dimitri Apostal [email protected] wrote:

I tried making changes on a new computer and I seem to be running into some build issues.

When I build for "Any CPU" it causes a runtime error caused by mismatched process architecture.

System.BadImageFormatException: 'Could not load file or assembly 'CLIInterop, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. An attempt was made to load a program with an incorrect format.'

When I build for x86 as suggested, it causes a bunch of warnings about "std::wstring" not being part of the std library (the string header is never included).

Here are a few of the errors

1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(21): error C2039: 'wstring': is not a member of 'std' 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(20): note: see declaration of 'std' 1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(21): error C2061: syntax error: identifier 'wstring' 1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C2039: 'wstring': is not a member of 'std' 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(20): note: see declaration of 'std' 1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C2065: 'wstring': undeclared identifier 1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C2923: 'std::vector': 'wstring' is not a valid template type argument for parameter '_Ty' 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(352): error C3203: 'allocator': unspecialized class template can't be used as a template argument for template parameter '_Alloc', expected a real type 1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(26): error C3203: 'vector': unspecialized class template can't be used as a template argument for template parameter '_Ty', expected a real type 1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(33): error C2039: 'wstring': is not a member of 'std' 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.23.28105\include\vector(20): note: see declaration of 'std' 1>C:\Users\japos\source\repos\indexer-plus-plus\Common\OutputFormatter.h(33): error C2065: 'wstring': undeclared identifier

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dfs-minded/indexer-plus-plus/pull/49?email_source=notifications&email_token=ADJD437IRK4J7NIWTK5KARTQPN3STA5CNFSM4GXVJA22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBX5ADQ#issuecomment-544198670, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJD43536YL4K7VE4HBMTMDQPN3STANCNFSM4GXVJA2Q .

[Stateford]

@dfs-minded Hello, I have found the one missing library but I still run into an error:

1>c:\users\japos\source\repos\indexer-plus-plus\indexertest\indexmanagertest.cpp(58): error C2039: 'CheckUpdates': is not a member of 'indexer::IndexManager'
1>c:\users\japos\source\repos\indexer-plus-plus\searchengine\indexmanager.h(33): note: see declaration of 'indexer::IndexManager'
1>c:\users\japos\source\repos\indexer-plus-plus\indexertest\indexmanagertest.cpp(62): error C2039: 'CheckUpdates': is not a member of 'indexer::IndexManager'
1>c:\users\japos\source\repos\indexer-plus-plus\searchengine\indexmanager.h(33): note: see declaration of 'indexer::IndexManager'

when I look at the code I see this:

#ifdef SINGLE_THREAD
        void CheckUpdates();
#endif

This flag looks like it's not enabled in the preprocessor.

[Stateford]

Looks like it could build in release and not debug.