swash icon indicating copy to clipboard operation
swash copied to clipboard

deps: Update `yazi` and `zeno` to current

Open waywardmonkeys opened this issue 1 year ago • 3 comments

waywardmonkeys avatar Sep 09 '24 01:09 waywardmonkeys

I tried to make sure that rendering still worked by using the swash_render example in Parley, but that was broken on main already.

waywardmonkeys avatar Sep 09 '24 01:09 waywardmonkeys

Doing a workaround in Parley to fix that example and then building with this version of swash still renders.

waywardmonkeys avatar Sep 09 '24 01:09 waywardmonkeys

@dfrg FYI

waywardmonkeys avatar Sep 11 '24 16:09 waywardmonkeys

I believe updating zeno is a semver breaking change since that crate is publicly re-exported. I’ve held off on doing this because I was trying to think of other breaking changes that might be valuable to include. At the very least, no_std support would be nice.

Since cosmic-text and its users depend on this, I’m trying to be conservative with breaking changes.

dfrg avatar Sep 23 '24 22:09 dfrg

At the very least, no_std support would be nice.

Hint received!

waywardmonkeys avatar Sep 24 '24 10:09 waywardmonkeys

Updated / rebased forward after 0.1.19.

waywardmonkeys avatar Oct 07 '24 03:10 waywardmonkeys

Thanks all and sorry for the delay. On a related note, would anyone like maintainer status on this repo to help land PRs?

dfrg avatar Nov 06 '24 18:11 dfrg

Thanks all and sorry for the delay. On a related note, would anyone like maintainer status on this repo to help land PRs?

I would be up for this. I wouldn't necessarily be confident reviewing more invasive changes. But I could definitely help land lint fixes, dependency bumps, CI changes, and such. Perhaps it would be good if a couple of us had permissions (@waywardmonkeys? @xorgy? @xStrom?) then we could merge each other's PRs.

nicoburns avatar Nov 07 '24 03:11 nicoburns

Thanks Nico. Invite sent. I’m also happy to add any of the others you listed but I don’t want to foist responsibility on anyone.

dfrg avatar Nov 07 '24 03:11 dfrg

@dfrg I would like it, if for no other reason than to be able to label issues/pulls, and maybe go back and make tags and release notes.

xorgy avatar Nov 07 '24 04:11 xorgy

I can join the party too.

waywardmonkeys avatar Nov 07 '24 04:11 waywardmonkeys

Thanks, invites sent.

dfrg avatar Nov 07 '24 05:11 dfrg

Sure I'll take the invite too. I can do an occasional review.

xStrom avatar Nov 07 '24 12:11 xStrom

Thanks Kaur, sent to you as well. Looks like we’re in good shape for reviews now.

dfrg avatar Nov 07 '24 13:11 dfrg