parley icon indicating copy to clipboard operation
parley copied to clipboard

update peniko to 0.5

Open rydb opened this issue 5 months ago • 6 comments

Updates peniko to 0.5. Uses specific vello commit for example while the new crate with peniko 0.5v hasn't been pushed yet.

rydb avatar Oct 01 '25 21:10 rydb

the test seems to be failing because vello requires rust edition 2024 but this project is in 2021. Should I edit the pr to also update to 2024?

rydb avatar Oct 01 '25 21:10 rydb

The solution to this may be to move the vello_editor example out of the workspace and make a standlone crate. Or we can just bump MSRV for Parley.

Given that this is just for an example, it probably makes sense to wait until vello 0.6 has been published to land this (should be soon).

nicoburns avatar Oct 01 '25 22:10 nicoburns

https://github.com/linebender/parley/releases/tag/v0.6.0 is out now, so we can make this update happen, I think.

Bumping MSRV to match Vello should be fine.

DJMcNab avatar Oct 15 '25 08:10 DJMcNab

vello requires rust edition 2024

Wait, what do you mean by that? You mean Vello has a higher MSRV?

PoignardAzur avatar Oct 28 '25 12:10 PoignardAzur

vello requires rust edition 2024

Wait, what do you mean by that? You mean Vello has a higher MSRV?

yes, vello's MSRV is 1.86.

rydb avatar Oct 28 '25 15:10 rydb

You don't need to change the edition then, only to raise the MSRV of vello_editor. No need to move it out of the workspace.

PoignardAzur avatar Oct 28 '25 16:10 PoignardAzur

Let's handle this as part of a Vello 0.7 upgrade once that's released.

nicoburns avatar Jan 09 '26 18:01 nicoburns