Dan Freeman

Results 228 comments of Dan Freeman

I don't think I would expect this to work; in general preprocessor addons don't apply to files in addons' `app` trees. It's the same reason addons in the wild have...

That's a fair point. The short answer is that ECM cheats and reaches outside the bounds of what it _really_ should be doing in its preprocessor implementation, as a result...

Sorry, I should have been clearer 🙂 > Addon supplying sass files for the app I got that much, but what specifically are you trying to supply from the addon?...

👍 All our stuff in shared addons is exposed via `compose`-able classes and `@values`, but we don't use Sass, so haven't really felt the pain around the edges like this....

Hi @bartocc, sorry for the long silence here! The short answer is that ECM intentionally doesn't treat the `styles` directory of an app or addon as special, since if you're...

To make sure I'm understanding right, your goal is to have ECM emit a single `.scss` file for the addon that the host app can then define variables for and...

I see, so it's not the host app that's defining the variables? In that case I think your problem is still roughly what I described, but it's solvable because you...

You might be able to do `@import 'node_modules/@org/addon/addon/styles/variables';` 🤔

This is probably a bug in ECM's template AST transform for `local-class`. I'm probably not going to have a chance to look into this in the next couple of weeks,...

Hi @emattias, thanks for the issue report! We delegate to the standard `css-modules` set of PostCSS plugins for the majority of the actual processing here, so this incompatibility will need...