Dan Foreman-Mackey
Dan Foreman-Mackey
That issue is one that I've hit before (https://github.com/exoplanet-dev/exoplanet/issues/92) but I never found a solution. This is caused by some lower level compiler issue that I've never been able to...
@Alina6618: This is definitely a Windows-specific issue, but it's one that I'd like to figure out at some point! In the meantime, using a Mac might be easier, but I...
Thanks Daniel! It looks like there's currently a syntax error - make sure that you can import the package and run the tests!
@iancze: I feel like you'll have thoughts about this...?
For the 1st use case, folks should generalize the [SimpleTransitOrbit](http://exoplanet.dfm.io/en/stable/user/api/#exoplanet.orbits.SimpleTransitOrbit) implementation instead of the KeplerianOrbit or TTVOrbit. I'm not excited about implementing that, but I would definitely be keen to...
@gjgilbert: Awesome! I think that the best first step would be a mash up of `SimpleTransitOrbit` [[src](https://github.com/dfm/exoplanet/blob/master/src/exoplanet/orbits/simple.py)] with `TTVOrbit` [[src](https://github.com/dfm/exoplanet/blob/master/src/exoplanet/orbits/ttv.py)] to make a `SimpleVariationOrbit` (?) that takes all the same...
Yes - I'm imagining that `TTVOrbit` would inherit from `KeplerianOrbit` and `VariationOrbit` (?), and that `SimpleVariationOrbit` (?) would inherit from `SimpleTransitOrbit` and `VariationOrbit`. No rush! Let's stay in touch.
Dang me too! I've been so swamped that I've not made much progress recently, but I'll revisit soon!
@kazewong — Any updates from your end? Let us know if there are any remaining issues! (Aside: @marylou-gabrie it looks like your authorship checkbox got unchecked - was that on...
@kazewong — Great! In that case can you update [your checklist above](https://github.com/openjournals/joss-reviews/issues/4634#issuecomment-1201257586)? I'm still seeing some boxes unchecked. Thanks!