Dan Foreman-Mackey

Results 547 comments of Dan Foreman-Mackey

@kazewong, @marylou-gabrie — Just a quick check in here to keep this on your radar. Let us know if you run into any issues!

@minaskar — I wanted to check in here since I think we're waiting on your responses to @kazewong, @marylou-gabrie's final small comments. Let us know if anything isn't clear or...

@kazewong, @marylou-gabrie — Can you both take a look at @minaskar's responses to your feedback and let us know if there are any remaining issues? Thanks!!

@castillohair: Thanks for this! Two major comments immediately: 1. There are merge conflicts because the implementation has been moved to `src/corner/core.py` instead of `corner/corner.py`. 2. I think it would be...

@castillohair — Thanks for the update! It would be great to add a test for this new feature in [`tests/test_corner.py`](https://github.com/dfm/corner.py/blob/main/tests/test_corner.py). Take a look [here](https://corner.readthedocs.io/en/latest/install/#tests) for info about running the tests....

This is perfect! I'm happy to merge this now. Thanks @castillohair!

Using the `hist_kwargs` should work.

I'd be happy to merge a pull request that adds more detail to the `levels` description (I agree that it's a bit lacking currently) and perhaps a softening of the...

I doubt that you have data backing up your "vast majority" there, but either way (as above) you're welcome to submit a pull request that adds wording that would satisfy...

@valerio-marra: that's not what you were concerned about in your previous comment and I disagree with you about the use of "correct" being confusing. It might annoy you (sorry!) but...