gulp-jasmine-phantom icon indicating copy to clipboard operation
gulp-jasmine-phantom copied to clipboard

Passing all the options to phantomjs causes issues when using vendor scripts with certain characters on windows

Open Nysosis opened this issue 8 years ago • 0 comments

If I've got the following config:

		{
			jasmineVersion: 2.4,
			integration: true,
			keepRunner: true,
			vendor: [
				"https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js",
				"https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.11.2/moment.min.js",
				"node_modules/jasmine-jquery/lib/jasmine-jquery.js",
				"node_modules/humanize-duration/humanize-duration.js",
				"node_modules/zebra_dialog/public/javascript/zebra_dialog.src.js",
				"./src/js/!(*.spec.js|!(*.js))"
			]
		}

The execution will fail, I believe it's down to the '!' in the pattern, not working well with windows (could be a *nix thing too, I've not the environment to test on).

All the arguments are being passed across at index.js#L220 and index.js#L181, however from what I can see, the jasmine-runner.js only really cares about the abortOnFail property from the configuration at line L16.

Nysosis avatar Dec 14 '16 09:12 Nysosis