dfir-toolkit
dfir-toolkit copied to clipboard
Feature/zip2bodyfile
add zip2bodyfile
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.85%. Comparing base (
e978e71) to head (9bb7369).
:exclamation: Current head 9bb7369 differs from pull request most recent head 5351569
Please upload reports for the commit 5351569 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## develop #27 +/- ##
===========================================
+ Coverage 33.68% 33.85% +0.17%
===========================================
Files 36 36
Lines 1140 1143 +3
===========================================
+ Hits 384 387 +3
Misses 756 756
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Can you recheck this with another tool? Times are matching on my system, when using unzip and 7z
However, zip seems to be using local time instead of UTC. Hmm....
I added an integration test. Could you please provide another one which fails on your test data?
I added the failing test and test data. What is making me curious is that the simplest change to the files within the ZIP archive leads to zip2bodyfile detecting the "correct" timestamps. Also I was not able to manually create a failing ZIP archive but the old one I had still reproduces the error.