vscode-motoko icon indicating copy to clipboard operation
vscode-motoko copied to clipboard

Deployment change and autocomplete for Principal type

Open mmyslblocky opened this issue 1 year ago • 5 comments

We changed the method of deploying canisters via extension from sending the canister code in motoko to playground Deployer Canister and instead we added deployment through CLI by sending deployment commands to vscode terminal. We also added functionality to start local replica and deploy canisters to local node. The minor drawback of our solution is that we cannot automatically open Candid UI when canister deployment is finished because we VSCode Terminal API does not support reading output so we need to manually open Candid UI after deployment of canister is finished by selecting this option.

We've added auto complete for Principal primitive type and for shared function principal argument. There's suggestion for every available Principal method with short description.

mmyslblocky avatar Sep 23 '24 11:09 mmyslblocky

Dear @mmyslblocky,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

sa-github-api avatar Sep 23 '24 11:09 sa-github-api

I think I adjusted the code to your review remarks, so you can verify these changes. I also signed the CLA agreement

mmyslblocky avatar Oct 13 '24 22:10 mmyslblocky

Thank you for the updates. We are still deciding whether it makes sense to include these changes, since adding a dependency on dfx will break some of the functionality on native Windows.

The other question is whether we want to implement a more systematic autocompletion for all imports rather than just Principal. We are currently looking for someone who could do this as part of a developer grant in case you're interested in taking this a step further.

rvanasa avatar Oct 17 '24 21:10 rvanasa

@rvanasa Are you still looking for someone to implement a more systematic autocompletion for all imports?

piotrswierzy avatar Dec 09 '24 10:12 piotrswierzy

Hi @piotrswierzy, we now have a team working on this as part of a developer grant.

rvanasa avatar Dec 10 '24 16:12 rvanasa

Closing since we ended up going with a different approach.

rvanasa avatar May 28 '25 16:05 rvanasa