vessel icon indicating copy to clipboard operation
vessel copied to clipboard

escape branch name

Open chenyan-dfinity opened this issue 3 years ago • 1 comments

Trying to fetch base from branch joachim/no-word

{ name = "base"
        , repo = "https://github.com/dfinity/motoko-base"
        , version = "joachim/no-word"
        , dependencies = [] : List Text
        }

vessel install fails, maybe due to / in the branch name?

$ vessel install
[INFO] Installing 3 packages
[INFO] Downloading tar-ball: "base"
[WARN] Downloading tar-ball failed, cloning as git repo instead: "base"
Error: No such file or directory (os error 2)

chenyan-dfinity avatar Apr 07 '21 22:04 chenyan-dfinity

Yeah it's because of the slash. I'm thinking I'd prefer to improve the error message here instead and forbid slashes in version. You can always use a commit hash instead.

kritzcreek avatar Apr 08 '21 07:04 kritzcreek

Closing since package names and versions are now restricted to letters, numbers, dashes, underscores, and the . character.

rvanasa avatar Feb 08 '23 22:02 rvanasa