sdk icon indicating copy to clipboard operation
sdk copied to clipboard

BUG: A motoko upgrade should never have the option to ignore stable compatiblity errors.

Open crusso opened this issue 9 months ago • 0 comments

The code here:

https://github.com/dfinity/sdk/blob/5a823d1107256d1334d41dc0f696d17f111a5676/src/dfx/src/lib/operations/canister/install_canister.rs#L115

is dangerous because it permits the user ignore any stable compatibility errors which may lead to loss of data.

This is more dangerous than ignoring the candid compatibility error, because users can always fix the candid interface with an upgrade, but once data is lost, it's gone or corrupted forever.

Is it possible to skip/ask for consent on stable compatibility warnings only but never, ever ignore stable compatibility errors?

@luc-blaeser - do you agree with proposal?

crusso avatar Apr 02 '25 09:04 crusso