nns-dapp icon indicating copy to clipboard operation
nns-dapp copied to clipboard

Published 20 hours ago • verified publisher icon dfinity

Set a default ledger canister ID

Open bitdivine opened this issue 10 months ago • 2 comments

Motivation

The ledger canister ID is now required. That means that deployments that don't include the ledger canister ID in the arguments will fail.

Changes

  • Set the ledger canister ID for the __default network to the mainnet canister ID.
    • This is our existing practice for other NNS canisters such as nns-governance.
    • Most test environents, and non-prod deployments to mainnet, use the same canister ID as mainnet.
  • Update tests to match.

Tests

  • Existing CI tests should pass.
  • Deployments to an app subnet on mainnet should work out of the box, without setting a custom canister ID.

Todos

  • [ ] Add entry to changelog (if necessary).

bitdivine avatar Apr 18 '24 13:04 bitdivine

Note: I don't understand the Playwright tests well enough to understand what is happening with them. A front end developer will need to investigate. @mstrasinskis maybe?

bitdivine avatar Apr 29 '24 07:04 bitdivine

It looks like transactions aren't being loaded during the e2e test. I guess it's getting the wrong index canister ID. Which probably means that here it now gets an index canister ID that's different from the ID of the index canister installed in the snapshot: https://github.com/dfinity/nns-dapp/blob/212cd61293c0dfab212c0722b51c6d1a2822cd9f/.github/actions/start_dfx_snapshot/action.yaml#L98 Is that possible?

dskloetd avatar Apr 29 '24 08:04 dskloetd