motoko icon indicating copy to clipboard operation
motoko copied to clipboard

bug: issue-4625 repro

Open crusso opened this issue 1 year ago • 3 comments

Non-dfx repro for issue #4625

crusso avatar Aug 15 '24 10:08 crusso

Maybe this should be under test/fail, then?

ggreif avatar Aug 15 '24 11:08 ggreif

I'm not sure how fixable this is. I wonder if design/IDL-Motoko.md is underspecified on how to translate Motoko/Candid references to type definitions, i.e. translate without or after expansion and that affects the translation of argument sequences.

In addition, both Motoko Null and () map to the Candid null.

so type X = () translates to type X = Null but func f(x : X) : async X has Candid type () -> () (I think), not, null -> null.

crusso avatar Aug 15 '24 11:08 crusso

Comparing from 9b67c0ccdea1d02f5e5027f73b7bc15b4ac2c716 to 79710b146765ab1a85d647352b66593a10836fdf: The produced WebAssembly code seems to be completely unchanged.

github-actions[bot] avatar Aug 15 '24 12:08 github-actions[bot]

Just doing some repo cleanup for better focussing on active work: Closing PR as it seems inactive for a longer time. Please re-open if it is still relevant and after it has been updated with latest master changes.

luc-blaeser avatar Dec 03 '24 09:12 luc-blaeser