motoko-base icon indicating copy to clipboard operation
motoko-base copied to clipboard

Motoko Base gives warnings on DFX deploy.

Open tiagoicp opened this issue 1 year ago • 2 comments

Hi,

It seems two added functions are causing warnings, today upgraded to latest version of both dfx (motoko) and base and I can't do anything to solve these warnings. Screenshot 2024-01-19 at 11 33 28

One seems to be related with an ongoing discussion: https://github.com/dfinity/motoko-base/issues/598 Tagging @kentosugama due to last change, and @timohanke and @ottodevs due to be the participants of the discussion.

The other seems to be related with this recent addition: https://github.com/dfinity/motoko-base/commit/be273ffdf9b4f915fc02f584397659f5a95748f9 Tagging @ZenVoich and @rvanasa due to being involved with that commit.

Kindly let me know if it's possible to fix 🙏 Thanks

tiagoicp avatar Jan 19 '24 11:01 tiagoicp

Thanks for pointing this out! I opened a PR to fix the Array.take() warning for the next base library release. I'll also bring the other warning message to the attention of the team in case we can roll out a fix for this as well.

rvanasa avatar Jan 19 '24 19:01 rvanasa

I now updated to 0.10.4 and also get a flood of these warnings.

Gekctek avatar Feb 08 '24 20:02 Gekctek