motoko-base icon indicating copy to clipboard operation
motoko-base copied to clipboard

Un-deprecate Array Append

Open kentosugama opened this issue 2 years ago • 3 comments

Array append is a useful function, and so should not be deprecated.

Documentation still includes warning of its linear complexity and suggestions to use a buffer instead.

kentosugama avatar Feb 10 '23 20:02 kentosugama

Drive-by comment: Being useful is not a sufficient condition for supporting a feature, almost every imaginable feature is useful in certain situations, yet most are counter-productive in the grand scheme of things. This one likely is unknowingly misused 95% of the time, no matter what the docs will say.

rossberg avatar Feb 14 '23 09:02 rossberg

Maybe we could use the unicode :warning: symbol to silence warnings on identifiers. Only half joking.

crusso avatar Feb 16 '23 01:02 crusso

Maybe keep append deprecated, but just rename it to concat which imo is a better name for the joining of two arrays (most people won't use it to append just a single item).

ByronBecker avatar Mar 01 '23 05:03 ByronBecker

#630 did this. Closing.

ggreif avatar Jul 08 '24 10:07 ggreif