interface-spec icon indicating copy to clipboard operation
interface-spec copied to clipboard

[FINAL] feat: [EXC-1676] add allowed viewers variant to canister's log visibility

Open maksymar opened this issue 1 year ago • 4 comments

This PR adds allowed_viewers variant to canister's log_visibility which allows to fetch logs by specified number of principals.

maksymar avatar Jul 27 '24 14:07 maksymar

One more point from the Interface spec meeting: should the canister itself be allowed to fetch the logs implicitly, just like it can fetch the canister status even if the canister does not control itself?

mraszyk avatar Jul 30 '24 13:07 mraszyk

One more point from the Interface spec meeting: should the canister itself be allowed to fetch the logs implicitly, just like it can fetch the canister status even if the canister does not control itself?

As long as we don't allow fetch_canister_logs through composite queries then the canister cannot really fetch the logs. Or you mean that the canister would make an HTTPS outcall to fetch the logs? I doubt that would be particularly useful to anyone.

dsarlis avatar Aug 01 '24 07:08 dsarlis

Or you mean that the canister would make an HTTPS outcall to fetch the logs?

That won't work implicitly anyway as the HTTPS outcall would have a self-authenticating caller that would need to be whitelisted explicitly.

mraszyk avatar Aug 11 '24 16:08 mraszyk

@dfx-json The PR looks good to me, but the feature is still disabled in production so I haven't approved yet.

mraszyk avatar Oct 24 '24 04:10 mraszyk