interface-spec icon indicating copy to clipboard operation
interface-spec copied to clipboard

[FINAL] feat: new System API call ic0.call_cycles_add128_up_to

Open mraszyk opened this issue 1 year ago • 2 comments

This PR adds a new System API call ic0.call_cycles_add128_up_to moving the maximum amount of cycles from the canister cycles balance onto an inter-canister call up to a specified upper bound.

mraszyk avatar Jun 14 '24 06:06 mraszyk

🤖 Here's your preview: https://nlbfx-nyaaa-aaaak-qcnzq-cai.icp0.io/docs

github-actions[bot] avatar Jun 14 '24 06:06 github-actions[bot]

Looks good to me for marking it final, would like to get the opinion from @dsarlis as well.

LGTM as well. One small nit regarding the value we return through dst.

dsarlis avatar Jul 02 '24 15:07 dsarlis

Removing the FINAL tag since we need to validate whether the API is actually practically usable.

Dfinity-Bjoern avatar Sep 03 '24 13:09 Dfinity-Bjoern