ic icon indicating copy to clipboard operation
ic copied to clipboard

chore(consensus): remove some unnecessary validator metrics

Open kpop-dfinity opened this issue 1 year ago • 0 comments

  1. These metrics are unused
  2. They don't track what they are supposed to: the description says Number of (...) shares being validated every block but we never reset the counter so in reality it counts the total number of validated shares
  3. They are not accurate: we don't increment the counter when some validations fail (e.g. parent hash mismatch or when random tape height = 0) or we double count some shares when the validation failed due to some transient error

kpop-dfinity avatar Oct 09 '24 09:10 kpop-dfinity