agent-rs icon indicating copy to clipboard operation
agent-rs copied to clipboard

feat: add delegation identity

Open flyq opened this issue 2 years ago • 4 comments

Description

Added DelegationIdentity

Fixes # (issue)

https://github.com/dfinity/agent-rs/issues/347

How Has This Been Tested?

I new a DelegationIdentity, and call the canister on chain, it works

Checklist:

  • [ ] The title of this PR complies with Conventional Commits.
  • [ ] I have edited the CHANGELOG accordingly.
  • [ ] I have made corresponding changes to the documentation.

flyq avatar Jun 07 '22 15:06 flyq

Dear @flyq,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA[^1].

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation [^1]: Contributor License Agreement

dfinity-droid-prod[bot] avatar Jun 07 '22 15:06 dfinity-droid-prod[bot]

Dear @flyq,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA[^1].

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation [^1]: Contributor License Agreement

dfinity-droid-prod[bot] avatar Jun 07 '22 15:06 dfinity-droid-prod[bot]

Thanks a lot for your PR! Have you considered adding a few tests to make sure it works as expected?

sesi200 avatar Jun 13 '22 12:06 sesi200

Thanks a lot for your PR! Have you considered adding a few tests to make sure it works as expected?

You're welcome. I will add tests. I would love to hear any other review suggestions

flyq avatar Jun 22 '22 00:06 flyq