agent-js icon indicating copy to clipboard operation
agent-js copied to clipboard

agent: requests to replica should have dfx version and ic-ref client info

Open gobengo opened this issue 5 years ago • 7 comments

via: https://dfinity.slack.com/archives/CGA566TPV/p1600410292001800

Why?

  • It will help replica team track usage of different dfx versions across different nets

gobengo avatar Sep 21 '20 15:09 gobengo

@nomeata @hansl fyi

gobengo avatar Sep 21 '20 15:09 gobengo

Would a custom header for this need to be defined in ic-ref spec? Or is there already a place to 'extend' or sandbox new features?

gobengo avatar Sep 21 '20 15:09 gobengo

@nomeata Are there any issues in other repos or tools that this can link to? That we we could coordinate making changes at similar times.

gobengo avatar Sep 21 '20 15:09 gobengo

We could document this in ic-ref. But since it's meant to be informative, but not actually relevant for the behavior of the system, I'd say just go ahead and include such a header, without a full-fledged design process

nomeata avatar Sep 21 '20 16:09 nomeata

HTTP header?

gobengo avatar Sep 21 '20 16:09 gobengo

Dfx-Version: 1.2.3

WDYT?

hansl avatar Sep 21 '20 18:09 hansl

Also, Accept-Ic-Spec: 1.2.3, 4.5.6, 7.8.9

hansl avatar Sep 21 '20 18:09 hansl