ICRC-1 icon indicating copy to clipboard operation
ICRC-1 copied to clipboard

Published 20 hours ago • verified publisher icon dfinity

Unclear spender_subaccount in ICRC-2

Open sea-snake opened this issue 1 year ago • 4 comments

TransferFromArgs contains spender_subaccount : opt blob in the readme but not in the did file, what is correct? Should it be added to did file or removed from readme?

sea-snake avatar Jul 14 '23 16:07 sea-snake

In both cases the spender should be an Account. I checked now and it looks like it is. Can you check again?

MarioDfinity avatar Jul 26 '23 10:07 MarioDfinity

In both cases the spender should be an Account. I checked now and it looks like it is. Can you check again?

Its missing in transfer from args at: standards/ICRC-2/ICRC-2.did

sea-snake avatar Jul 26 '23 11:07 sea-snake

Oh I see. Yes it's missing, there should be a spender_subaccount in TransferFromArgs as you said.

MarioDfinity avatar Jul 26 '23 11:07 MarioDfinity

https://github.com/dfinity/ICRC-1/pull/138 addresses this

MarioDfinity avatar Jul 26 '23 13:07 MarioDfinity