jsdom-screenshot icon indicating copy to clipboard operation
jsdom-screenshot copied to clipboard

Change puppeteer to peer dependency?

Open peterjosling opened this issue 3 years ago • 1 comments

This package specifies puppeteer ^1.12.2 as a dependency, which is a version that is pinned to Chrome 73. As this is a dependency of the package, there's no way to specify a different Chrome version.

Changing puppeteer to be a peer dependency would allow users of the package to specify their own version of puppeteer and be in control of the version of Chrome that gets used.

peterjosling avatar Nov 13 '20 22:11 peterjosling

Thanks for the hint @peterjosling!

iirc, the puppeteer api had a breaking change. If we make it a peer dep, we should update our puppeteer usage to ensure we can support the latest version (and update the readme/install instructions)

dferber90 avatar Nov 15 '20 04:11 dferber90