jsdom-screenshot icon indicating copy to clipboard operation
jsdom-screenshot copied to clipboard

Published 20 hours ago • verified publisher icon dferber90

Usage with Typescript

Open kylerjensen opened this issue 4 years ago • 3 comments

Anything on the roadmap for adding Typescript definitions to this library? If not, I can add something to DefinitelyTyped.

kylerjensen avatar Jun 01 '20 20:06 kylerjensen

Thanks for reaching out! This package was an experiment a while ago and I'm a bit surprised by the growing usage :) I started using TypeScript since writing it.

A conversion of the repo to TypeScript might be nicer than maintaining separate types on DefinitelyTyped. If you feel like it, you can convert the repo to TypeScript. I'd accept a PR.

I am not planning on doing it myself as I'm not actively using this package anymore. You could become a maintainer if that's something you're interested in.

dferber90 avatar Jun 01 '20 22:06 dferber90

@dferber90 you're not actively using this package, are you using another mechanism for visual snapshotting?

llinardos avatar Mar 06 '23 15:03 llinardos

I'm not doing VRT at the moment, but I'd recommend something like https://percy.io/

dferber90 avatar Mar 06 '23 15:03 dferber90