Doug Fawley

Results 474 comments of Doug Fawley

This was implemented in #6224.

@mrahs, > I'm considering copying the relevant code over under an "internal" directory here to remove the direct dependency on the experimental API. Maybe I'm misunderstanding, but I don't know...

> Since the grpc-go version is pinned here If you are a binary and not a library, then this will work for you in theory until you need to update...

> Is the client expected to close the entire pool if one connection fails? If a ClientConn has a lost connection, it would re-establish the connection on its own. But...

> I'm still not sure how best to exclude connections in bad state from the pool We do have an API to show the connectivity state of the channel as...

> The method I found GetState is also experimental: grpc/grpc-go@e88e849/clientconn.go#L738 Ah, right. I don't think we particularly like that API since it's lossy (i.e. you can miss a temporary state),...

All custom LB policies use experimental code, as the balancer package itself is experimental. :) I still recommend starting with what I mentioned in the initial comment, and let me...

I don't think I would use that interface instead of a `*grpc.ClientConn` with type assertions in order to close. Instead, I'd define my own interface like: ```go type grpcClientConn interface...

I believe #6031 implemented this.