Doug Fawley

Results 458 comments of Doug Fawley

Sounds great - let us know if you need anything!

It would be nice if @Lucaber or @JaydenTeoh are able to reproduce the original issue and then confirm that the fix in #6672 truly fixes the issue. Maybe @Lucaber can...

Also it appears the fix is incomplete. We need to make sure we're setting the keepalive socket option as appropriate (see https://github.com/grpc/grpc-go/pull/6672#discussion_r1386248342).

There are a lot of moving pieces in a system like this, and so this will be hard to help, here. Some things to consider: - Do you track the...

https://github.com/grpc/grpc-go/actions/runs/5094637292/jobs/9158695833?pr=6314#step:8:342

@arvindbr8 is out of town until when @easwars gets back so reassigning to @easwars.

> I called with `grpc.MaxCallRecvMsgSize(math.MaxInt64)` This is definitely wrong. The _most_ you'd ever want to do is `math.MaxInt`. And even that is a pretty insane maximum. The intent of this...

As mentioned in the PR, this could be fixed by limiting the allowable values in `MaxCallRecvMsgSize` to `math.MaxInt64-1`. The PR as submitted is incorrect, as we need to be able...

Maybe being removed in #6188

@avinilcodes - I can gladly assign this to you, but right now it seems very ambiguous. Do you think you'll be able to assess the tests in our repo and...