Doug Fawley

Results 459 comments of Doug Fawley

The two examples of this that we found were ORCA and OpenCensus instrumentation. OC "needs" to be first because it won't include anything before it in the call latency. This...

https://github.com/grpc/grpc-go/actions/runs/5764499645/job/15628580120?pr=6505#step:8:200

Unfortunately with @arvindbr8 and @easwars out of town we are a bit short staffed right now. Will resume in ~2 weeks if that's okay, thanks!

> This includes allocation that are actually garbage collected I believe this is by design. More allocations = slower and more frequent GC cycles = worse expected performance.

We need a second review before merging PRs from external contributors.

This looks wrong: https://github.com/grpc/grpc-go/blob/417d4b6895679bd9378cb37c2afecf6a292eb267/credentials/alts/alts_test.go#L324-L327 Can you take a look, please @matthewstevenson88? This test is flaking which can delay our development cycles.

No, this issue is unowned and not in progress. I'll assign it to you, thanks!

Interesting. This behavior of storing the context away for future use by the token source is definitely not clear from the docstring here: https://pkg.go.dev/golang.org/x/oauth2/google#FindDefaultCredentialsWithParams > Not sure how it worked...

I've dug through the oauth2 code for some time and I'm still unsure of how the context is being used. At this point, though, I'm confident that if there _is_...

We have several people out of the office for an extended amount of time, so this is unlikely to get any attention for a few weeks, sorry.