Daniel Faust

Results 90 comments of Daniel Faust

What operating system are you using?

What operating system are you using? And how are you creating the file? You are receiving a `Create` and then a `Modify` event. Looks good to me.

> if you drop the instance without `commit` it may leave the watcher in an inconsistent state (especially fsevents). So if I'm getting this right: When the `FsEventPathsMut` is used...

> Ok, I'll delete it By deprecating it, I meant marking it with the `deprecated` attribute: ```rust #[deprecated(since = "9.0.0", note = "paths_mut has been replaced with update_watches")] ``` Btw....

Also, if the PathsMut compatibility API is the same as the current one, then we can release it as a feature update (v. 8.3.0). I would wait a day and...

@riberk Sorry, I don't have much mental capacity right now. I will try to look at it on the weekend. Please send me a reminder if I forget.

I like it. But I don't have a mac to test it.

@riberk You are very welcome to do so. But be careful, these tests used to be extremely flaky. That's why we removed them at some point. In order to be...

ping @worr Is that an issue with the kqueue or notify crate?

Hi @hugwijst. Sorry that reviewing this PR took so long. It looks good and I would like to merge it. Can you please fix the conflict and also add an...