Daniel Falbel comments

Results 245 comments of


                                            Daniel Falbel

Building lantern with CUDA and existing libtorch

That makes sense! In theory you could do something like: `install_torch(path = "~\libtorch")` and then use the `TORCH_HOME="~\libtorch"` env var to always use the same installation directory. Does that work...

Test coverage

I only know Github Actions + Codecov.io Do you have other suggestions?

Test coverage

Sure! I will take this work item, so it's easier to configure accounts and etc. There's definitely a lot of room for improvements in the test coverage!

support torch_device() and how it's used

I explored this in the #127 but didnt have success... Will wait to see if I get answers in the forum.

[Feature request] Warn when overwriting modules of nn_sequential

Hey @sebffischer ! THanks for filing this issue! I guess I see why this would be helpful, but I also can imagine that users could have patterns where overwriting assigned...

Non-cuda GPU support

This is not possible because LibTorch does not support other backends, although they seem to be working on a AMD Rocm device and support for new M1 macs. I think...

Non-cuda GPU support

I am starting to update to libtorch 1.8 here: https://github.com/mlverse/torch/pull/513 and we will probably be able to use ROCm, however note that currently there are no binaries for LibTorch with...

Non-cuda GPU support

Yeah, we could do that! I have a workflow here to build LibTorch https://github.com/dfalbel/declarations/blob/master/.github/workflows/main.yaml We would need to figure out how to build it with ROCm support. Probably following something...

Non-cuda GPU support

Support for M1 GPU's is now done :) I don't plan adding support for AMD GPU's as I don't have hardware to try it. Happy to help if someone is...

torch_bernoulli() is failing on device="cuda" with Error : Expected a 'cuda' device type for generator but found 'cpu'

Thanks @cregouby . This is indeed a bug. I'll work on a fix soon