DepFA

Results 122 comments of DepFA

Do we want to be putting more operations of variable 'correctness' (I'd have cropped for the sphinx in the centre of the frame!) into preprocess when there's a world of...

You're right, insane. I'm surprised you're not exposing the `prompt` parameter to allow textually guided clipping.

Why did you call this "paste CLIP" in all caps? https://openai.com/blog/clip/

the `list[Path]` error implies you're on an old version of python prior to [3.6?] with the old type specification conventions. Please confirm your current python version and upgrade to 3.11...

Presumably because some of the upscalers upscale by a fixed multiplier and a single pass isn't going to get you to your requested size if it's larger than that multiplier....

Users can do that by setting the scale factor to less than or equal to the model's trained resizing, one could argue that the comparison is perhaps off in the...

Just looked at your other linked PR, is your motivation here that the 3 times loop is repeating on the 1x networks? If that's the case then why not check...

Apologies, I didn't realise you'd introduced that bug yourself in #3976! Everything will need to be 'upscaled' or at least filtered once, due to it being a size increase or...

Looks good, do we want to retain the `img = img.resize((int(dest_w), int(dest_h)), resample=LANCZOS)` pass even if `upscale_loop=False` is set? Seems to spoil the purity of getting a direct one pass...

I think the only real danger is `scale-to` ![image](https://user-images.githubusercontent.com/35278260/200028984-d1550a40-484f-4eb4-aae2-7087168d9a36.png) getting too small an image and not being able to crop it as requested.