pg_filedump icon indicating copy to clipboard operation
pg_filedump copied to clipboard

Fix masking changing values in tests

Open GetsuDer opened this issue 1 year ago • 0 comments

After running make installcheck for postgres a few times, make installcheck for pg_filedump fails:

@@ -86,17 +86,17 @@
  Item   2 -- Length:  256  Offset: 7888 (0x1ed0)  Flags: NORMAL
 COPY: long inline uncompressed	xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
  Item   3 -- Length:   64  Offset: 7824 (0x1e90)  Flags: NORMAL
-  TOAST value. Raw size:     2804, external size:     2800, value id:  ....., toast relation id:  ....., chunks:      2
+  TOAST value. Raw size:     2804, external size:     2800, value id: 106494, toast relation id: 106492, chunks:      2
 COPY: external uncompressed	0123456789
  Item   4 -- Length:  107  Offset: 7712 (0x1e20)  Flags: NORMAL
 COPY: inline compressed pglz	0123456789
  Item   5 -- Length:   67  Offset: 7640 (0x1dd8)  Flags: NORMAL
-  TOAST value. Raw size:   280004, external size:     3226, value id:  ....., toast relation id:  ....., chunks:      2
+  TOAST value. Raw size:   280004, external size:     3226, value id: 106495, toast relation id: 106492, chunks:      2
 COPY: extended compressed pglz	0123456789
  Item   6 -- Length:   90  Offset: 7544 (0x1d78)  Flags: NORMAL
 COPY: inline compressed lz4	0123456789
  Item   7 -- Length:   66  Offset: 7472 (0x1d30)  Flags: NORMAL
-  TOAST value. Raw size:   700004, external size:     2772, value id:  ....., toast relation id:  ....., chunks:      2
+  TOAST value. Raw size:   700004, external size:     2772, value id: 106496, toast relation id: 106492, chunks:      2
 COPY: extended compressed lz4	0123456789

This is caused by masking in tests considering the va_valueid, va_toasterlid (Oid) to be five digits long, which is not always true. Also with checksums now on by default make installcheck for pg_filedump on REL_18 fails too.

GetsuDer avatar Nov 11 '24 08:11 GetsuDer