dragonfly icon indicating copy to clipboard operation
dragonfly copied to clipboard

Player move method doesn't keep position locked, causing potential race conditions

Open Sandertv opened this issue 3 years ago • 2 comments

Sandertv avatar Jun 20 '21 20:06 Sandertv

This turns out to be a bit harder than initially expected, because the player handler has to be called in the middle of the Move method. This means that any call during that handler that accesses the player position would result in a deadlock if we kept that position locked for the duration of the method.

Sandertv avatar Jul 30 '21 12:07 Sandertv

What if we only pass deltas to HandleMove, so we don't have to lock before HandleMove is called

T14Raptor avatar Oct 05 '21 15:10 T14Raptor