homerow icon indicating copy to clipboard operation
homerow copied to clipboard

Safari search bar and certificate overlap

Open hunterliao29 opened this issue 3 years ago • 1 comments

Describe the bug

In some case, like in screenshot, Certificate(u) and search bar(v) will overlap. when select (v) it will open (u)

Screenshots / video Screenshot 2023-02-04 at 9 34 34 PM

Steps to reproduce the bug

  1. Go to safari
  2. open brew.sh
  3. Click on search bar
  4. see error

hunterliao29 avatar Feb 05 '23 02:02 hunterliao29

Since Homerow clicks most UI elements in their center, there's a chance two UI elements have have their hitbox in that click position.

I can see two potential fixes:

  1. Verifying that the UI element at the click position matches the one that Homerow has selected, using AXUIElementCopyElementAtPosition. If not, then try another coordinate within the focused UI element's bounds.
  2. Issuing an AXFocus action instead of left clicking. I don't want to do this because that doesn't solve for the right-click, double-click, and modifier-click cases.

Option 1 will have some performance penalties that lead to delay when clicking. I think I'll sit on it for a while since (I assume) its a rare occurrence.

dexterleng avatar Feb 05 '23 03:02 dexterleng