helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

add commonLabels, commonAnnotations, podLabels and podAnnotations

Open ecthelion77 opened this issue 4 years ago • 2 comments

Overview

What this PR does / why we need it

Special notes for your reviewer

Checklist

  • [ ] Change log updated in Chart.yaml (see the contributing guide for details)
  • [ ] Chart version bumped in Chart.yaml (see the contributing guide for details)
  • [ ] Documentation regenerated by running make docs

ecthelion77 avatar Nov 25 '21 10:11 ecthelion77

/assign @sagikazarmark

ecthelion77 avatar Nov 25 '21 16:11 ecthelion77

Thanks for submitting a PR!

To be honest, I'm not sure I understand why all this change is necessary to implement this feature.

  • Why the added dependency?
  • Why the formatting changes in values.yaml?
  • Documentation format is not followed in values.yaml

I'd probably just modify the dex.labels template and create another one called dex.annotations.

Even then, I'm not sure why this feature is necessary: most objects already support adding custom labels and annotations.

sagikazarmark avatar Mar 28 '22 11:03 sagikazarmark