helm-charts
helm-charts copied to clipboard
add commonLabels, commonAnnotations, podLabels and podAnnotations
Overview
What this PR does / why we need it
Special notes for your reviewer
Checklist
- [ ] Change log updated in
Chart.yaml(see the contributing guide for details) - [ ] Chart version bumped in
Chart.yaml(see the contributing guide for details) - [ ] Documentation regenerated by running
make docs
/assign @sagikazarmark
Thanks for submitting a PR!
To be honest, I'm not sure I understand why all this change is necessary to implement this feature.
- Why the added dependency?
- Why the formatting changes in values.yaml?
- Documentation format is not followed in values.yaml
I'd probably just modify the dex.labels template and create another one called dex.annotations.
Even then, I'm not sure why this feature is necessary: most objects already support adding custom labels and annotations.