helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Use HTTPS port for Ingress when enabled

Open JoooostB opened this issue 2 years ago • 0 comments

Overview

When enabling HTTPS, the ingress still forwards traffic to the service over HTTP. This PR sets the destination port to the HTTPS port when .Values.https.enabled is true.

What this PR does / why we need it

Enabling HTTPS currently does nothing for the communication between the ingress and the service, defeating the purpose altogether. With this PR HTTPS is also used between the service and ingress (when complemented with the necessary annotation for nginx).

Special notes for your reviewer

Checklist

  • [x] Change log updated in Chart.yaml (see the contributing guide for details)
  • [x] Chart version bumped in Chart.yaml (see the contributing guide for details)
  • [x] Documentation regenerated by running make docs

Signed-off-by: Joost Buskermolen [email protected]

JoooostB avatar Dec 01 '22 09:12 JoooostB