Add support for additional IdP authentication parameters in OIDC connector

Open a-nych opened this issue 1 year ago • 1 comments

Overview

This PR is a refresh of https://github.com/dexidp/dex/pull/2631 by @roddyherries.

Some IdPs support login features that are accessible via additional parameters on an authorization request. The current OIDC connector implementation provides no mechanism to configure additional authorization request parameters and hence the IdP specific features are out of reach. This PR adds support to for such additional params to the OIDC connector.

What this PR does / why we need it

Adds a new "additionalAuthRequestParams" map to the OIDC Config struct Populates the map from config at connector "open" Adds any additional auth params to the auth LoginURL Prevents mis-configuration attempts to override OIDC specified auth params.

Special notes for your reviewer

Issue: https://github.com/dexidp/dex/issues/2504

Nov 07 '24 09:11 a-nych

Hi, so, what's the current state of this? Also interested in this. If I understood correctly, the suggested changes from the review in #2631 are applied in here? What would be the next steps? Rebase, fix linter issues, request review?

Sep 19 '25 09:09 mardonner