dex
dex copied to clipboard
fix: remove redundant scope check from Google connector
Overview
Remove redundant scope check from Google connector to fetching groups available.
What this PR does / why we need it
Since groups are not considered a valid scope by Google, we cannot pass to the scope. Although @damieva introduced claimMapping in https://github.com/dexidp/dex/issues/2653 to address this issue, it does not seem to work with the current implementation of the Google connector.
This commit resolves the issue by removing the unnecessary group scope check, as adminSrv is only initialized when the user wants to retrieve groups.
Special notes for your reviewer
None
Does this PR introduce a user-facing change?
NONE
HI @devholic
Thanks for the contribution! I honestly can't say how it's supposed to work, because we don't have an extensive test environment yet (I'm working on that).
I need to figure out what's going on, because this part of the code is known to have bugs and broke quite a few times.
Please give us some time to review and figure out what's going on.
@sagikazarmark
No problem, Thanks! :)
Hey @sagikazarmark, I was wondering if I could get an update for this PR (No rushes 🙂)
Any chance this PR will make it in? 😄 Latest is unfortunately still broken, thus forcing us to rely on generating a customer docker container.