dexidp
Use `display-name` for Crowd user names
Overview
Modifies the Atlassian Crowd connector to set the name claim to the user's full name and adjusts supporting code in response.
This is a breaking change.
Some feedback around how to handle refreshes would be appreciated, as unlike other connectors Crowd doesn't assume that the preferred username is set (which is now the only place the login username is persisted in the token)
What this PR does / why we need it
#2644 notes that the Crowd connector does not provide the full name of the user, though Crowd itself does provide it. This is unlike most other connectors and the OAuth2 specification and is surprising to consumers.
Special notes for your reviewer
Authentication to the group checking endpoints now uses the user ID provided by the authentication flow instead of the identity.Username, since the attribute is now the full name and not the same ID that was provided initially.
Does this PR introduce a user-facing change?
The Atlassian Crowd connector now returns the user's full display name instead of their username in the `name` claim. Clients that require the username should set the `preferredUsernameField` of the connector configuration to `name`.
