ESPAsyncDNSServer icon indicating copy to clipboard operation
ESPAsyncDNSServer copied to clipboard

Make AsyncDNS arduino-esp32-compatible

Open drws opened this issue 4 years ago • 8 comments
trafficstars

Currently ESPAsyncDNSServer includes ESPAsyncUDP with #include <ESPAsyncUDP.h>. However, AsyncUDP is natively included in arduino-esp32 since 2018 and can be included in Arduino ESP32 projects with #include <AsyncUDP.h> only. Currently, this library is not compatible with arduino-esp32 out-of-the-box or am I missing anything?

drws avatar Mar 03 '21 11:03 drws

I don't use esp32, and I don't plan to in the near future. However, if you make a PR I'll take a look.

devyte avatar Mar 21 '21 02:03 devyte

@drws use this on ESP32: https://github.com/guestisp/ESP32AsyncDNSServer

guestisp avatar May 20 '22 15:05 guestisp

Proposed PR has been merged.

devyte avatar May 21 '22 19:05 devyte

thank you

guestisp avatar May 24 '22 06:05 guestisp

This change is not reflected in the version PlatformIO installs automatically. This caused errors about missing dependencies for esp8266 when compiling my esp32 project.

I do not know how the PlatformIO Registry is updated, or who is responsible. Maybe @devyte can push the update somehow?

bradjshannon avatar Dec 15 '22 04:12 bradjshannon

I don't know about pushing anything, I don't use PIO myself, so I have no idea how this lib is integrated there. But I can make changes within this repo if that helps anyone. So if anyone knows what needs to be done here, or better yet: proposes the needed changes in a PR, I can look into it.

devyte avatar Dec 15 '22 15:12 devyte

I bet if you just change the version number, it'll trigger PIO to get the latest?

bradjshannon avatar Dec 17 '22 15:12 bradjshannon

PR open for this in #6.

maxgerhardt avatar Dec 29 '22 14:12 maxgerhardt