MoyaSugar icon indicating copy to clipboard operation
MoyaSugar copied to clipboard

Raise Moya dependency to v15

Open kambala-decapitator opened this issue 3 years ago • 5 comments

While podspec change isn't strictly required, I changed it from >= to ~> for consistency with SPM.

kambala-decapitator avatar Sep 28 '21 09:09 kambala-decapitator

It works well to me. in Podfile

pod 'MoyaSugar', :git => 'https://github.com/kambala-decapitator/MoyaSugar.git', :commit => 'eca6cfdb24cf1e8108ed7772bc6beb3643a80453'
pod 'MoyaSugar/RxSwift', :git => 'https://github.com/kambala-decapitator/MoyaSugar.git', :commit => 'eca6cfdb24cf1e8108ed7772bc6beb3643a80453'

But SPM is not working due to Moya issue

0k1019 avatar Mar 31 '22 02:03 0k1019

@0k1019 not sure why you're using my branch with Cocoapods: existing podspec in the main repo already allows using Moya v15

kambala-decapitator avatar Mar 31 '22 06:03 kambala-decapitator

https://github.com/devxoul/MoyaSugar/blob/079f25af9798977885058895085051379755bc7c/MoyaSugar.podspec#L22

In master branch, there is no Moya v15 update. So, I use your repo commit. If my action interferes you, I will remove it.

0k1019 avatar Mar 31 '22 06:03 0k1019

@0k1019 >= operator allows any later version unlike the ~> one which would've locked you to v14.

it doesn't interfere with me in any way, I'm just trying to make your Podfile setup simpler :)

kambala-decapitator avatar Mar 31 '22 06:03 kambala-decapitator

Oh, My mistake. Think you so much! My Podfile is simple thanks to your comment!

0k1019 avatar Mar 31 '22 07:03 0k1019