git-phlow icon indicating copy to clipboard operation
git-phlow copied to clipboard

Don't fail silently when phlow.token is missing

Open praqma-thi opened this issue 7 years ago • 3 comments

I just went through the git phlow with Johan, but struggled a bit at the start. It silently failed whenever we wanted to interact with issues, but --verbose helped. The phlow.token wasn't configured, (nor was GHI installed, but I don't know if that's still a requirement).

It could be nice to get an error message on that, though.

praqma-thi avatar Feb 16 '18 15:02 praqma-thi

Your console log output would be nice, I'm not fully sure how to reproduce.

But never the less, I think it makes sense to make this issue about never failing silent at all. Every time we can't recover from a problem or fail automatically, we should explain to the user what went wrong and fail with a noticeable error message.

buep avatar Feb 18 '18 08:02 buep

Console log was on Johan V.'s machine. He uses a Mac. Maybe I can get him to remove the plow.token and run some more commands again. I'll set up a reminder, maybe snag him on a Friday.

praqma-thi avatar Feb 20 '18 07:02 praqma-thi

No worries, we would have to reproduce in a test anyway... so just if some more information about reproducing would also be fine.

And as mentioned, this issues should be about not failing silently.

buep avatar Feb 22 '18 09:02 buep