Paul Gschwendtner comments

Results 173 comments of


                                            Paul Gschwendtner

docs(guide): Updated event-listeners.md doc to use correct term, even -> every

@JeanMeche should we add `action: review` if the PR still has pending reviewers?

docs(guide): Updated event-listeners.md doc to use correct term, even -> every

This PR was merged into the repository by commit a89fd30690ef34e2c80cf4e4266e7f2e74d28e3b. The changes were merged into the following branches: main, 18.2.x

Initializer APIs (input, output, queries) not integrating with `TestBed.override` in a jit & aot mix

@alxhub yeah, we'd need to convert the extracted metadata into a decorator basically, unless we start introducing a whole new parameter for "initializer APIs— Ideally we'd use the JIT transforms...

Failed to import @angular/core or other modules. Error 500

Awesome, thank you! will this rate limiting be removed in the future? (you mentioned it as being "temporary")

Failed to import @angular/core or other modules. Error 500

I don't seem to get these 500 errors anymore, thanks! On the other hand, I see some QUIC errors and larger files from e.g. `@angular/compiler` end up being never cached...

[20.0.x]: Patch port of #61843, and #61826

Rebased but this got conflicted again. I will merge myself tomorrow morning.

[20.0.x]: Patch port of #61843, and #61826

This PR was merged into the repository by commit e98ef808aa3bb293cb8e04e3c70500414863f3dd. The changes were merged into the following branches: 20.0.x

Run jasmine tests with karma_web_test and karma_web_test_suite

We're using Web Test Runner via https://github.com/devversion/rules_browsers with Puppeteer, but it's also not super great— but at least allows us to stay on the Jasmine test runner (which simply runs...

Run jasmine tests with karma_web_test and karma_web_test_suite

@mollyibot depends on which interactions you need. This ruleset is mostly for our Angular needs, but it supports WTR (as Karma replacement) + there is a rule for Protractor testing....

Output migration transforms eventEmitter.emit() into invalid output.emit()

I agree that we could add a TODO, or skip in "safe mode", but IMO it would also be acceptable to say that we are intentionally breaking here and surfacing...