devtron icon indicating copy to clipboard operation
devtron copied to clipboard

namespace cache operations on cluster deletion

Open iamayushm opened this issue 1 year ago • 2 comments

Description

Fixes #

Checklist:

  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] Does this PR requires documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have tested it for all user roles.
  • [ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


iamayushm avatar Sep 23 '24 11:09 iamayushm

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13816532 Triggered Generic Private Key 246c8cf34a46093adb53b1907fef8757d1bfd5d8 vendor/github.com/google/s2a-go/testdata/mds_client_key.pem View secret
10220829 Triggered Generic High Entropy Secret 1f7995ee1f6610b4680b1c5835ee0555e4b7bb00 charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret 1f7995ee1f6610b4680b1c5835ee0555e4b7bb00 charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret af5f36db4367721ed5e7d2058adc948914c979fb devtron-images.txt.source View secret
10220829 Triggered Generic High Entropy Secret 508a70b0d1c52d9a998dcc9fe0e0a8cbf37801c4 charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret 508a70b0d1c52d9a998dcc9fe0e0a8cbf37801c4 charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 9eabc1215369b9bf0778774df7924762497d6e4b charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 9eabc1215369b9bf0778774df7924762497d6e4b charts/devtron/devtron-bom.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Sep 23 '24 11:09 gitguardian[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Sep 30 '24 12:09 sonarqubecloud[bot]