fix: handling side-effects for displaying external helm apps with same name across diff namespaces and clusters

Open prakash100198 opened this issue 1 year ago • 3 comments

Description

This pr handles the case when external helm apps with same name exists in diff namespaces and diff clusters, handling is done by storing display name, along with unique appName in app_name column of apps table ("displayName-ns-clusterId") for external helm apps (in case same name ext helm app exists across diff ns or cluster)

Fixes #4805

Checklist:

[ ] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR requires documentation updates?
[ ] I've updated documentation as required by this PR.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have tested it for all user roles.
[ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

Apr 16 '24 12:04 prakash100198

PR is not linked to any issue, please make the corresponding changes in the body.

Apr 21 '24 20:04 github-actions[bot]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
10220829	Triggered	Generic High Entropy Secret	ed1248f97ba5b1d142f332f725d5c4e7fc1e113d	charts/devtron/values.yaml	View secret
10220829	Triggered	Generic High Entropy Secret	ed1248f97ba5b1d142f332f725d5c4e7fc1e113d	charts/devtron/devtron-bom.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}