devtron icon indicating copy to clipboard operation
devtron copied to clipboard

feat:wire nil test in pre ci pipeline

Open Laeeqdev opened this issue 1 year ago • 2 comments

Description

Created the 'wireNilCheck' function to identify nil fields within data. Scripts were devised to run this function within a Docker container, facilitating its integration into our Continuous Integration (CI) pipeline without port forwarding. This allows us to validate data integrity early in the process, ensuring that any nil fields are caught and handled appropriately to prevent pipeline failure during pre-CI checks.

Checklist:

  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] Does this PR requires documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [ ] I have tested it for all user roles.
  • [ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Laeeqdev avatar Apr 01 '24 05:04 Laeeqdev

⚠️ GitGuardian has uncovered 10 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10190659 Triggered Generic High Entropy Secret 910d88ffa1c5d437a3ffa9f327cbf0b86e3eb3e6 wireNil.env View secret
10190659 Triggered Generic High Entropy Secret 1102b85c41022fd1d5d2377aee13887b5898b185 wireNil.env View secret
10190659 Triggered Generic High Entropy Secret 04dafc1e8e5334e84dae763f8e5f3d1236d3f018 wireNil.env View secret
10190659 Triggered Generic High Entropy Secret 1df34c699a2a398b1423281c3d7d5e8385d061c0 wireNil.env View secret
10190660 Triggered Generic Password 910d88ffa1c5d437a3ffa9f327cbf0b86e3eb3e6 tests/integrationTesting/devtron-secret.yaml View secret
10190660 Triggered Generic Password 04dafc1e8e5334e84dae763f8e5f3d1236d3f018 tests/integrationTesting/devtron-secret.yaml View secret
10190661 Triggered Generic Password 910d88ffa1c5d437a3ffa9f327cbf0b86e3eb3e6 wireNil.env View secret
10190661 Triggered Generic Password 04dafc1e8e5334e84dae763f8e5f3d1236d3f018 wireNil.env View secret
10220829 Triggered Generic High Entropy Secret 92fe5b4ff41fb136a97df3d79bd16037e6887791 charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 92fe5b4ff41fb136a97df3d79bd16037e6887791 charts/devtron/devtron-bom.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Apr 05 '24 10:04 gitguardian[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Apr 24 '24 09:04 sonarqubecloud[bot]

PR is not linked to any issue, please make the corresponding changes in the body.

github-actions[bot] avatar May 21 '24 13:05 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar May 21 '24 14:05 sonarqubecloud[bot]