chore: App Store refactoring v4

Open Ash-exp opened this issue 6 months ago • 2 comments

Description

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

[ ] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR requires documentation updates?
[ ] I've updated documentation as required by this PR.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have tested it for all user roles.
[ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

Feb 08 '24 06:02 Ash-exp

⚠️ GitGuardian has uncovered 25 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
6669482	Triggered	PGP Private Key	ab5c595215fda055fb01dcf76bf9b5013f56f741	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
6669482	Triggered	PGP Private Key	d52c0a43e71a2c5cb4e6bd48a8083f635cb61f82	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
6669484	Triggered	PGP Private Key	d52c0a43e71a2c5cb4e6bd48a8083f635cb61f82	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
6669484	Triggered	PGP Private Key	ab5c595215fda055fb01dcf76bf9b5013f56f741	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
9404168	Triggered	Username Password	93e635b9ab65a9b26f7f33fabd791b7f6a22e40d	internal/util/ArgoUtil/ArgoClient.go	View secret
9257608	Triggered	Base64 AWS keys	bf86180a1b9f3874ab1718ec7f599b462b67a9cd	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json	View secret
9257608	Triggered	Base64 AWS keys	ece34197b5a8d341b44f76423db0b5c722c87783	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json	View secret
9257608	Triggered	Base64 AWS keys	fe0f272d567a57d7a49c091c98f6bd58678e4257	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json	View secret
6669483	Triggered	PGP Private Key	d52c0a43e71a2c5cb4e6bd48a8083f635cb61f82	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
6669483	Triggered	PGP Private Key	ab5c595215fda055fb01dcf76bf9b5013f56f741	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
9498692	Triggered	Generic Password	01eca29bf9e844deb4b65593dc8d1d779b3f86c6	pkg/gitops/GitOpsConfigService.go	View secret
2763127	Triggered	Generic High Entropy Secret	bf86180a1b9f3874ab1718ec7f599b462b67a9cd	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	bf86180a1b9f3874ab1718ec7f599b462b67a9cd	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	fe0f272d567a57d7a49c091c98f6bd58678e4257	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	ece34197b5a8d341b44f76423db0b5c722c87783	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	fe0f272d567a57d7a49c091c98f6bd58678e4257	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	ece34197b5a8d341b44f76423db0b5c722c87783	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	bf86180a1b9f3874ab1718ec7f599b462b67a9cd	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	fe0f272d567a57d7a49c091c98f6bd58678e4257	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	ece34197b5a8d341b44f76423db0b5c722c87783	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	fe0f272d567a57d7a49c091c98f6bd58678e4257	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	ece34197b5a8d341b44f76423db0b5c722c87783	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	bf86180a1b9f3874ab1718ec7f599b462b67a9cd	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml	View secret
6669481	Triggered	PGP Private Key	d52c0a43e71a2c5cb4e6bd48a8083f635cb61f82	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
6669481	Triggered	PGP Private Key	ab5c595215fda055fb01dcf76bf9b5013f56f741	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}