devtron icon indicating copy to clipboard operation
devtron copied to clipboard

Feature: Expose heap dump api internally on port other than 80 / 443 and remove authentication for orchestrator

Open tayalrishabh96 opened this issue 1 year ago • 5 comments

🔖 Feature description

Expose heap dump api internally on port other than 80 / 443 and remove authentication for the same for orchestrator

🎤 Pitch / Usecases

As of now heap dump api requires super admin token, the use-case is to be able to take heap dump without generating super admin token. current api to take heap dump : curl -H 'token: <apiToken>' https://<orchestrator_service_url.devtroncd>/orchestrator/debug/pprof/heap requirement is something like below : curl https://<orchestrator_service_url.devtroncd>:<some_port>/orchestrator/debug/pprof/heap

🔄️ Alternative

NA

👀 Have you spent some time to check if this issue has been raised before?

  • [X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

AB#8360

tayalrishabh96 avatar Feb 06 '24 06:02 tayalrishabh96

❌ There was a problem linking to Azure Boards work item(s):

  • 8360

Please check the IDs and try again using the AB# syntax. Learn more

azure-boards[bot] avatar Feb 06 '24 06:02 azure-boards[bot]

❌ There was a problem linking to Azure Boards work item(s):

  • 8360

Please check the IDs and try again using the AB# syntax. Learn more

azure-boards[bot] avatar Feb 06 '24 06:02 azure-boards[bot]

❌ There was a problem linking to Azure Boards work item(s):

  • 8360

Please check the IDs and try again using the AB# syntax. Learn more

azure-boards[bot] avatar Feb 06 '24 06:02 azure-boards[bot]

❌ There was a problem linking to Azure Boards work item(s):

  • 8360

Please check the IDs and try again using the AB# syntax. Learn more

azure-boards[bot] avatar Feb 06 '24 06:02 azure-boards[bot]

  • We won't be removing authentication from endpoint (Please discuss before picking)
  • Different port is required or not is purely tech call

abhibhaw avatar Feb 14 '24 06:02 abhibhaw

Not critical anymore as per discussion with @tayalrishabh96 @nishant-d

abhibhaw avatar Feb 22 '24 10:02 abhibhaw

We can take heap dumps for microservices other than orchestrator using proxy but authentication is not removed yet. No plans for the same.

tayalrishabh96 avatar Jul 30 '24 11:07 tayalrishabh96