feat: User defined git repo for GitOps deployment

Open Ash-exp opened this issue 9 months ago • 3 comments

Description

In Devtron, currently we create a repo for every application for storing GitOps data, if the org doesn’t want to give us create repo permission, it becomes an issue.

In this PR we gave this flexibility to users to choose whether they want us to create the repo or they want to create and provide us the URL

Fixes https://github.com/devtron-labs/devtron/issues/4308

How Has This Been Tested?

[x] GItOps Config CRUD
[x] Helm Chart GitOps Installation
[x] Helm Chart Chart Group Installation
[x] Helm Chart Bulk Installation
[x] Devtron App Level GitOps Config Create and Validate
[x] CD with GitOps
[x] CD with Helm
[x] GitOps Repo Migration

Checklist:

[x] The title of the PR states what changed and the related issues number (used for the release note).
[ ] Does this PR requires documentation updates?
[ ] I've updated documentation as required by this PR.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have tested it for all user roles.
[ ] I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

Nov 24 '23 04:11 Ash-exp

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9257608	Triggered	Base64 AWS keys	79b22f9b33a15d861a3aa0a2bdcb8e1e094695dd	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json	View secret
9498692	Triggered	Generic Password	23b8a4766f6089202754cf14308ef7ba69eb18f0	pkg/gitops/GitOpsConfigService.go	View secret
2763127	Triggered	Generic High Entropy Secret	79b22f9b33a15d861a3aa0a2bdcb8e1e094695dd	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	79b22f9b33a15d861a3aa0a2bdcb8e1e094695dd	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	79b22f9b33a15d861a3aa0a2bdcb8e1e094695dd	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	79b22f9b33a15d861a3aa0a2bdcb8e1e094695dd	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}