devstream icon indicating copy to clipboard operation
devstream copied to clipboard
verified publisher icon devstream-io

:four_leaf_clover: `Proposal`: pkg/util/helm Enhancement (sub task of pkg/util Enhancement #833)

Open jxs1211 opened this issue 3 years ago • 3 comments

What Would You Like to Add? Why Is This Needed?

see #833 for the details

changes:

  • refactor the 'NewHelm' for supporting customized Client and easier mocking
  • move 'AddOrUpdateChartRepo' out of the Constructor
  • add ut

ut result:

jxs1211 avatar Jul 12 '22 00:07 jxs1211

Thank you for your proposal :) ! Do you have any design proposal now? If so, we can discuss it together (maybe it needs help from someone familiar with helm) before we start writing the code, which can reduce a lot of unnecessary troubles.

iyear avatar Jul 12 '22 04:07 iyear

@iyear good advice, but I don't how to make a desgin propoal. Actually, I've wrote a helm's enhancement and prepared to commit, maybe I should hold it now

jxs1211 avatar Jul 12 '22 09:07 jxs1211

@jxs1211 If you've already written the code, please feel free to commit it, and the reviewers will follow up in PR. :)

iyear avatar Jul 12 '22 09:07 iyear